Skip to content

Notes about 1.0.0-beta.30 #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 18, 2019
Merged

Notes about 1.0.0-beta.30 #1375

merged 4 commits into from
Dec 18, 2019

Conversation

JessicaSachs
Copy link
Collaborator

  • Adding notes about async vs. sync mode.
  • Adding placeholder for mocking transitions section.

@hiendv
Copy link
Contributor

hiendv commented Dec 17, 2019 •
edited
Loading

I think we could also document wrapper.vm.$nextTick() as an interchangeable option to Vue.nextTick().

@lmiller1990
Copy link
Member

@JessicaSachs a bit about mocking transitions, 99% of the work was done by @hiendv , I hope you don't mind I used your example and sneaky transitionStub helper.

I'm excited to learn how Vue's <transition> works under the hood (have not used it much), and how we can let it work correctly in VTU as well.

@hiendv
Copy link
Contributor

hiendv commented Dec 17, 2019

@lmiller1990 It would be my honor. I've been using VTU for years but never had a chance (or time 🤣 ) to contribute back to the library. Glad you took my snippet which, to be honest, is kinda a skimmed version of the original by @eddyerburgh. I think the old component stubs could be a good start for you.

FloEdelmann
FloEdelmann suggested changes Dec 17, 2019
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming from #1367, I've got some remarks.

@FloEdelmann FloEdelmann mentioned this pull request Dec 17, 2019
Closed
@JessicaSachs JessicaSachs merged commit 79eab20 into vuejs:dev Dec 18, 2019
@JessicaSachs JessicaSachs deleted the docs/beta30-notes branch December 18, 2019 00:59
@JessicaSachs
Copy link
Collaborator Author

JessicaSachs commented Dec 18, 2019 •
edited
Loading

These docs will help provide guidance for 1.0.0-beta.30 migration-related issues

@vue-bot
Copy link

vue-bot commented Dec 18, 2019

Hey @JessicaSachs, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann requested changes

@dobromir-hristov dobromir-hristov dobromir-hristov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JessicaSachs @hiendv @lmiller1990 @vue-bot @FloEdelmann @dobromir-hristov